Contacts quality of life fixes #2738

tacryt-socryp · 2020-04-14T22:21:42Z

Fixes Can't remove myself from a group; crashes on my planet. #2488, Fixes can't leave my group after a personal breach #2696
Updates subscription.js to do subscriptions in two rounds for performance
Updates subscription.js to initiate new channel upon event source error.
Adds a synced path to contact-hook so that we can make a "you lost connection, resubscribe UI element" as a preliminary "workaround" for rejoining a group from a breached ship (need to discuss with @urcades for next steps?)
Suppresses printing of an error printf that isn't useful but that should happen

…loading

matildepark · 2020-04-14T23:51:04Z

pkg/interface/groups/src/js/components/lib/contact-card.js

        this.setState({awaiting: false});
        props.history.push(`/~groups${destination}`);
      });
+      api.contactView.delete(props.path);


I'm surprised this fires given we're about to push to another view.

The other call is asynchronous, but good point, I can remove the race condition.

I'm wondering why we call both the view and the hook here, instead of having the view call the hook for us. It already does that too, I believe:

urbit/pkg/arvo/app/contact-view.hoon

Lines 148 to 152 in 65cad93

%delete

%+ weld

:~ (group-poke [%unbundle path.act])

(contact-poke [%delete path.act])

(contact-hook-poke [%remove path.act])

The hook does not do the same action, as the contactHookRemove API in the JS is sending a contact-action to the group owner, not a contact-hook-action to ourselves.

But looking at this, I could make the view perform the action. Making this change.

urcades · 2020-04-15T00:22:29Z

@loganallenc happy to continue discussion in here, or present some thoughts around a renewed "reconnect" interface in an interface review at some point. Either way, I'll post up some thoughts/a link re: this pretty soon.

matildepark · 2020-04-15T03:29:10Z

The two fixes aren’t QoL, they’re bugs; if the design iteration is minor (within a day) then sure, otherwise, don’t necessarily hold this back.

tacryt-socryp · 2020-04-15T03:37:26Z

Agreed, I want to implement the display / resubscribe flow within contacts later, but wanted to alert Ed to the details of it. This is good to go as is.

Fang-

(Also noticed that contact-hook seems to do (some of) the same that I fixed for chat-hook in #2746. Not saying that needs to change now, but we should keep it in mind.)

pkg/arvo/sur/contact-hook.hoon

Fang- · 2020-04-15T19:13:54Z

pkg/interface/groups/src/js/components/lib/contact-card.js

        this.setState({awaiting: false});
        props.history.push(`/~groups${destination}`);
      });
+      api.contactView.delete(props.path);


I'm wondering why we call both the view and the hook here, instead of having the view call the hook for us. It already does that too, I believe:

urbit/pkg/arvo/app/contact-view.hoon

Lines 148 to 152 in 65cad93

%delete

%+ weld

:~ (group-poke [%unbundle path.act])

(contact-poke [%delete path.act])

(contact-hook-poke [%remove path.act])

Fang- · 2020-04-15T19:21:41Z

pkg/arvo/app/contact-hook.hoon

    ^-  (list card)
    ::  local
    ?:  (team:title our.bol src.bol)
+      ?.  (~(has by synced) path)  ~


Why do we suddenly want to silently no-op instead of crash here?

Shouldn't this be above the team check, so we have consistent behavior (ie not crash) between local and foreign pokes?

Because the contact-hook ~(got by synced) can throw a noisy error message that doesn't matter as long as we have done the contact-view-delete.

we have done the contact-view-delete.

We shouldn't be calling this anymore if we've already done that, right? Or is my understanding of how we use this hook wrong?

I'm worried about this making the "we tried calling it but it's not there because of [some bug]" completely silent, harder to catch.

If the path isn't in synced, the remove method should do nothing.

Fang- · 2020-04-15T19:23:55Z

pkg/arvo/app/contact-hook.hoon

    :_  state
-    [%pass contact-path %agent [our.bol %contact-store] %watch contact-path]~
+    :~  [%pass contact-path %agent [our.bol %contact-store] %watch contact-path]
+        [%give %fact ~ %contact-hook-update !>([%initial synced])]


You probably want [%give %fact [%synced path.act]~ ... for this, and the %facts below? ~ outside of the "someone just subscribed" context just means "send this to nobody".

Might also be nice to refactor these into a +send-synced-update or some such card creation function.

Good point.

Fang- · 2020-04-15T20:02:58Z

pkg/arvo/lib/contact-json.hoon

+  %+  turn  ~(tap by synced.upd)
+  |=  [pax=^path shp=^ship]
+  ^-  [cord json]
+  [(spat pax) s+(scot %p shp)]


Might be slightly cleaner to use (ship:enjs:format shp) here. nbd

tacryt-socryp · 2020-04-21T17:31:26Z

I did some more in-depth testing yesterday and uncovered a reproducible group-hook bug relating to leaving and re-joining. Fixing today.

tacryt-socryp · 2020-04-21T19:19:58Z

This has been heavily tested and the style complaints satisfied.

Fang-

This seems good to go!

tacryt-socryp and others added 3 commits April 14, 2020 21:33

contacts: fix group deletion and do some quality of life fixes

b6e4566

contact-hook: tested it, got /synced path working, and subscriptions …

bfcaf64

…loading

contact-js: made channel handle onChannelError

0145981

tacryt-socryp requested review from ixv and matildepark April 14, 2020 22:21

matildepark reviewed Apr 14, 2020

View reviewed changes

matildepark requested a review from Fang- April 15, 2020 17:41

Fang- requested changes Apr 15, 2020

View reviewed changes

matildepark mentioned this pull request Apr 17, 2020

groups: breached group owner's recreated group doesn't show in sidebar #2726

Closed

matildepark linked an issue Apr 17, 2020 that may be closed by this pull request

groups: breached group owner's recreated group doesn't show in sidebar #2726

Closed

t groups + contacts: make removes completely clean up state

6d4a694

tacryt-socryp force-pushed the la-contact-delete-fix branch from 821eb1b to 6d4a694 Compare April 21, 2020 19:17

tacryt-socryp requested review from Fang- and removed request for ixv April 21, 2020 19:20

Fang- approved these changes Apr 21, 2020

View reviewed changes

jtobin merged commit 5b9887c into master Apr 22, 2020

jtobin deleted the la-contact-delete-fix branch April 22, 2020 10:05

	%delete
	%+ weld
	:~ (group-poke [%unbundle path.act])
	(contact-poke [%delete path.act])
	(contact-hook-poke [%remove path.act])

Uh oh!

Contacts quality of life fixes #2738

Contacts quality of life fixes #2738

Uh oh!

Conversation

tacryt-socryp commented Apr 14, 2020 • edited by matildepark Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

urcades commented Apr 15, 2020

Uh oh!

matildepark commented Apr 15, 2020

Uh oh!

tacryt-socryp commented Apr 15, 2020

Uh oh!

Fang- left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tacryt-socryp commented Apr 21, 2020

Uh oh!

tacryt-socryp commented Apr 21, 2020

Uh oh!

Fang- left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

tacryt-socryp commented Apr 14, 2020 •

edited by matildepark

Loading