groups: fix self destruct on kick #2841
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the remove functionality in contact-card.js incorrectly assumed that we are always removing ourselves from the group. Fixes #2816
tacryt-socryp
approved these changes
May 4, 2020
|
woah dope |
|
Please merge this as soon as it's tested to resolve the problem. It needs deployed as soon as possible as hoon school just imploded because of this. |
|
Is there anything at all we can do to OTA-fix the situation for people who hit this, or is the group completely gone? Could we look at permissions, or contacts? cc @loganallenc @liam-fitzgerald |
|
We’ll be pushing something tonight, @baudtack.
@Fang- do you want to jump into the ship and +dbug? Was it dopzod?
… On May 5, 2020, at 4:44 PM, Fang ***@***.***> wrote:
Is there anything at all we can do to OTA-fix the situation for people who hit this, or is the group completely gone? Could we look at permissions, or contacts? cc @loganallenc @liam-fitzgerald
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
This should be merged immediately. |
@baudtack's case lives on his own ship. I don't think I have direct access to anything where this occurred. @loganallenc and probably @liam-fitzgerald are more familiar with the logic here anyway, and might be able to y/n answer the "is anything even possible" question. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where kicking a member with contact info set would delete the group. Also fixes a bug where a group member leaving would not be propagated to the rest of the group
fixes #2816