Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@sigilante
Copy link
Collaborator

@sigilante sigilante commented May 4, 2020

#2843

I'll let you wizards add the case-insensitivity i at the end, JS isn't my scene.

@sigilante
Copy link
Collaborator Author

While we're on the subject, jpg? should be fine in the middle but that starts to get weird. Wish you could do a Unix-style scan of the file header without having to access the whole thing.

Copy link
Contributor

@tacryt-socryp tacryt-socryp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Fang-
Copy link
Collaborator

Fang- commented May 4, 2020

While we're on the subject, jpg? should be fine in the middle

I'd say you could just /(jpg|png|etc)($|\?.*)/ to match either end, of ? and whatever more might follow. Maybe that's a bit too permissive?

@ixv ixv merged commit 0c57e65 into urbit:master May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants