Per-ship Drum subscriptions #2867
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukechampine
commented
May 6, 2020
lukechampine
commented
May 6, 2020
lukechampine
commented
May 6, 2020
philipcmonk
requested changes
May 6, 2020
de96e56 to
378fbb9
Compare
lukechampine
commented
May 7, 2020
378fbb9 to
4217bfa
Compare
lukechampine
commented
May 7, 2020
lukechampine
commented
May 8, 2020
8379b7d to
8cbb8f1
Compare
philipcmonk
added a commit
that referenced
this pull request
May 8, 2020
philipcmonk
added a commit
that referenced
this pull request
May 8, 2020
This will fix the issue described in #2867 for ducts that have already triggered the bug. This will also send spurious acks for any messages that are outstanding at the time of the upgrade, but I don't believe this will cause a serious problem.
philipcmonk
approved these changes
May 8, 2020
philipcmonk
added a commit
that referenced
this pull request
May 22, 2020
* origin/release/link-dojo: chat-cli: allow sending • character chat-cli: always talk to local ship only chat-cli: single-target sole effects as needed chat-cli: don't allow excessively small cli widths chat-cli: pull in sole-sur namespace where relevant chat-cli: remove unused entropy from state chat-cli: print newlines correctly chat-cli: support multiple sole connections chat-cli: don't crash on %bad-text dojo: rename remote access generators gall: fix handling of empty path list dojo: remove unused %json poke dojo: add remote access controls drum: switch to per-ship /sole/drum duct Signed-off-by: Philip Monk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Huge thanks to @philipcmonk for explaining in detail how to accomplish this.
Previously,
|linkcouldn't be used across ships, because Drum always subscribes on/sole/drum, regardless of what ship it's talking to. This PR changes Drum to subscribe on/sole/drum_SHIPNAME, so that updates can be routed to the appropriate ship.This means that you can run
|link ~zod %dojo, hit Ctrl-X, and be dropped into zod's Dojo prompt! This could be used for e.g. administrating one ship from another; to allow a developer to debug your ship in-situ, etc.Of course, for security reasons, apps generally reject pokes from other ships. So I also added access controls to Dojo: in addition to checking the peer against
team:title, it will look for the ship in an access control list. So it's basicallysshfor Urbit, leveraging the built-in identity system instead of needing to copy public keys around. :)