links: namespace types #2882
links: namespace types #2882
Conversation
| @@ -1,7 +1,10 @@ | |||
| :: link: social bookmarking | |||
There was a problem hiding this comment.
I don't think I understand why this entire file was renamed from /lib/link to /lib/link-store. Makes sense for the json conversions, but the other functions here mostly operate on suite-wide data, rate?
There was a problem hiding this comment.
none of these are used outside the link store though. imo the idea of 'suite-wide' data is kinda vague because the store itself should always store the 'suite-wide' data
There was a problem hiding this comment.
You're right that it is a bit vague. My thinking there is that, even if you're interacting only with one of the hooks, you're still pulling in the core data types and working with those. Pulling in the store lib for that (which could very well contain helpers for interacting with the store) makes is slightly less obvious what you're actually touching. But it's also not the biggest deal.
|
should this be retargeted? |
|
next-userspace seems right for this, yeah. This seems good to go afaic. The "suite-wide" thing can always be revisited if it turns out it's a useful distinction later. |
Namespaces the links types according to the proposal in #2814 . I've made one minor change though, which is that the /sur/link-store file only contains types specific to the store. e.g.
action,updateandinitial. All the other types should go in sur/link which should be imported with a tar. I've made this change because of the sheer amount of types that links uses. If this is ok, I'll revise the chat PR to match this.cc: @loganallenc @ixv