chat: virtualize message-to-json only where needed #2887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we were virtualizing all message rendering operations, but it's only +tank:enjs:format that we're worried about here. Doing this more narrowly also allows us to specify a slightly more specific error message.
b1cc8d5 to
973cb62
Compare
|
Resolved merge conflict. @loganallenc please stamp. |
tacryt-socryp
approved these changes
May 20, 2020
|
CI failure seems spurious again? Probably fine to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #2879, which was written a bit hastily.
Previously we were virtualizing all message rendering operations, but it's only
+tank:enjs:format that we're worried about here.
Doing this more narrowly also allows us to specify a slightly more specific
error message.