meta: simplify contributing guides #3615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
matildepark
commented
Sep 29, 2020
- The interface dev environment is very simple to set up. This PR attempts to better exemplify that.
- Because there have been a few situations in which users get tripped up on fakezods using boot pills, I add instructions to use the solid pill and Arvo directory from the repository.
philipcmonk
approved these changes
Sep 29, 2020
Fang-
reviewed
Sep 29, 2020
Comment on lines
+30
to
+31
| Change the URL to your livenet ship (if making front-end changes) or keep it the | ||
| same (if [developing on a local development ship][local]). Then, from |
There was a problem hiding this comment.
My local ships have never bound to 80 because I have something else running locally. Might want a sidenote here about using whatever port the ship prints on boot.
There was a problem hiding this comment.
1 minute ago god damn it mark
There was a problem hiding this comment.
I'm willing to accept the tradeoff that anyone with something else running locally knows that ports exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.