king: Create a new stats subsystem; count some stuff in Ames #4075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eglaysher
approved these changes
Dec 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To address the problem of alleged dropped packets in kh, we add a bunch of counters at each step of the ames driver pipeline. The intent was for these to be part of a system like the SIGINFO/SIGUSR2 handler in classic vere, but it turned out, surprisingly and disappointingly, to be much easier to surface these via the new runtime subsite that @Fang- and I developed. So visit
/~_~/statto get your stats.We also append 32 bits of random to the end of the default log filename so you can keep your old logs. That way, when something goes wrong (e.g. oom), we have more insight into what it was even if the ship has been restarted.