vere: only compare to clay when committing files #4078
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of first comparing to a previously committed version of the file, which may or may not have been fully accepted by clay. Fixes #3240.
|
This change itself is not exceedingly urgent, it can be easily made in a post-breach runtime release. So I'm probably going to hold off on loading the problem into my head for now ... @philipcmonk is probably better situated for a quick review. |
|
@Fang- please re-open again release/next-vere, looks like this was autoclosed by accident and I can't seem to rebase it |
|
My bad, I forgot there were PRs still targeting this branch. |
|
Gentle ping, either @philipcmonk or @joemfb for review. |
joemfb
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of first comparing to a previously committed version of the
file, which may or may not have been fully accepted by clay.
Fixes #3240, though some of the discussion therein remains relevant.