chat-cli: mvp graph-store migration #4000
Conversation
Makes chat-cli listen to graph-store rather than chat-store. Along the way, cuts some features. No longer supports channel creation, deletion, permission management or inviting. No longer lets you send messages to multiple targets at once. No longer displays messages from all joined chats, and no longer lets you join or leave chats. Instead, chat-cli solely concerns itself with viewing chat content you're already subscribed to (through use of Landscape or other rich clients). ;view ~host/chat to start printing messages for that chat when they come in, ;flee to toggle off. ;view to see what chats are enabled, ;chats to see all available chats. The removal of features acknowledges chat-cli's lack of real support for the modern, group-centric state of userspace. The intent of ;view ux is to prepare chat-cli for a multi-session terminal world.
| ++ eval | ||
| |= [txt=cord exe=hoon] | ||
| (say %code txt (eval:store bowl exe)) | ||
| ~& %eval-tmp-disabled | ||
| [~ state] | ||
| ::TODO why -find.eval?? | ||
| :: (say %code txt (eval:store bowl exe)) |
There was a problem hiding this comment.
idk what's up with this, by the way. Nothing's shadowing store, nothing about this even changed, but it just won't resolve. What dumb mistake could I be overlooking?
|
Thank you for your work @Fang- |
|
Pointed at the current Chat -> graph-store migration location. @liam-fitzgerald can you review this? |
|
Is there at least still support for generators to manage channel state?
"Urbit is unusable without a web browser" feels deeply weird.
…On Thu, Dec 3, 2020 at 20:08, Liam Fitzgerald ***@***.***> wrote:
***@***.**** approved this pull request.
This looks good! Pushed a couple of changes for things I found while
testing, other than that LGTM!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4000 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOFPBVUPAIKRIZFYDBD76TSTBHBBANCNFSM4T624PUA>
.
|
|
You haven't been able to have complete parity with Landscape's web front-end for quite a while now — since around OS1, I think.
|
Makes chat-cli listen to graph-store rather than chat-store.
Along the way, cuts some features. No longer supports channel creation,
deletion, permission management or inviting. No longer lets you send
messages to multiple targets at once.
No longer displays messages from all joined chats, and no longer lets
you join or leave chats. Instead, chat-cli solely concerns itself with
viewing chat content you're already subscribed to (through use of
Landscape or other rich clients).
;view ~host/chatto start printingmessages for that chat when they come in,
;fleeto toggle off.;viewtosee what chats are enabled,
;chatsto see all available chats.The removal of features acknowledges chat-cli's lack of real support for
the modern, group-centric state of userspace.
The intent of
;viewux is to prepare chat-cli for a multi-sessionterminal world.
Opening this PR in case it needs to go in asap, but will try and find some time in the next 24 hours to add actual multi-session support to this.Multi-session support is in.The approach here is one of "minimum viable migration". The code style is (or rather, remains) a bit rough around the edges, but fixing that is not in scope here.
Tested this a bit by playing around with graph generators, think it's probably good, but want to test again once @liam-fitzgerald's frontend changes are in just to make sure this plays nice in "wilder" contexts. Message rendering should work fine, but might look a tad janky.
(I assume an updated
/mar/graph-validator/chat.hoon, withnotification-kind:growarm, will find its way intonext-userspace.)cc @syzygyzer for updating the messaging docs, though maybe we just want to remove chat-cli from the docs altogether for now.