push-hook: push out facts to each path only a single time #4149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philipcmonk
approved these changes
Dec 13, 2020
|
Nice
On Sat, Dec 12, 2020 at 6:15 PM Philip Monk ***@***.***> wrote:
***@***.**** approved this pull request.
We tested this on on ~bitpyx and it worked fine
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4149 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJBY56ZUUN53PQXCTBOGLSUQBSHANCNFSM4UY2RYLQ>
.
--
—
~poldec-tonteg
http://urbit.org
|
|
@liam-fitgerald let's talk today about how/when to deploy these fixes
—
~poldec-tonteg
http://urbit.org
…On Sat, Dec 12, 2020 at 8:42 PM Liam Fitzgerald ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#4149 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAMJBY4GMUOYLIFYTMDPV33SUQS2LANCNFSM4UY2RYLQ>
.
|
|
The root issue is worse than I initially expected, which is that n messages are sent per message where n is the number of ships on the channel. This issue is high enough priority to warrant a hotfix. In other words, we'll receive a greater than 10x performance gain for many of our larger groups, such as urbit-community. We could easily see a 100x improvement for large chat channels. |
|
(Where n is the number of ships on the channel that haven't been kicked). Should definitely go out as a hotfix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The push-hook library was iterating through incoming subscriptions and was sending out the same fact to the same path multiple times. It now taps the list of paths it takes in so as to deduplicate them prior to issuing facts. Perhaps this could be pulled up into Gall?
Thanks for helping me find this, @philipcmonk. This PR also turns back on noisy printing of duplicates in
%graph-store, because that will help us root out any future issues in the stack that cause duplicate messages to be sent. There won't be any duplicate facts anymore at present so the terminal will continue to be quiet.Messages sent over the
%push-hookwill now cause 10x less network traffic than they did previously.cc: @vvisigoth @matildepark The root cause has been found and resolved.