drum: update app index early when unlinking #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The added logic also happens in +se-drop, which will get called by +se-abet if we did unlink an application. But +se-agon depends on the index being sane, and may be called between +se-klin and +se-abet.
This lets applications suggest to the client that they should gracefully unsubscribe from the session. Arguably this might be accomplished by %kick-ing the client and then crashing on their subsequent resubscribe, but this requires tracking their sole session id and has less semantic clarity on what's happening.
joemfb
approved these changes
Dec 15, 2020
sole: add %bye effect for closing the session
This was referenced Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where ctrl-d-ing to unlink the current app would crash.
The added logic also happens in
+se-drop, which will get called by+se-abetif we did unlink an application. But+se-agondepends on theindex being sane, and may be called between
+se-klinand+se-abet.