Thanks to visit codestin.com
Credit goes to github.com

Skip to content

landscape: various regressions #4117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2020
Merged

landscape: various regressions #4117

merged 3 commits into from
Dec 11, 2020

Conversation

@matildepark
Copy link
Contributor

@matildepark matildepark commented Dec 10, 2020 •
edited
Loading

  • Adding writers and unmanaged channel creation has been silently broken after groups: better ship search validation #3998 because the ship search returns sig'd patps. Because we compare unsig'd patps everywhere the ship search is used and the invite popover desigs them anyway, I just removed the sig.
  • Snippet gradients would take up the full height of the screen in hark because position='relative' is no longer implicit in <Box> (indigo-react 1.2.15+). This passes the relative positioning for that instance.

This was referenced Dec 10, 2020
Closed
Closed
@matildepark matildepark merged commit 89f603e into release/next-userspace Dec 11, 2020
@matildepark matildepark deleted the mp/landscape/various branch December 11, 2020 00:06
@matildepark matildepark mentioned this pull request Dec 11, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@liam-fitzgerald liam-fitzgerald Awaiting requested review from liam-fitzgerald

1 more reviewer

@tacryt-socryp tacryt-socryp tacryt-socryp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@matildepark @tacryt-socryp