observe-hook: spider wasn't always issuing thread-results, so we got %watch-not-unique. we now make unique wires, but spider's issue remains #4119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…%watch-not-unique. we now make unique wires, but spider's issue remains
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4114. We got a repro on Isaac's ship and resolved it by making this change. This issue may be representative of a deeper issue in
%spiderwhere spider may not be issuing%thread-resultsdeterministically every time a thread is completed. Unsure. Regardless, no functionality was broken, and everything continues to work in this PR.cc @philipcmonk