Thanks to visit codestin.com
Credit goes to github.com

Skip to content

landscape: add woff2 support, serve Inter & Source Code Pro #4121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 4, 2021
Merged

landscape: add woff2 support, serve Inter & Source Code Pro #4121

merged 2 commits into from
Jan 4, 2021

Conversation

@tylershuster
Copy link
Contributor

@tylershuster tylershuster commented Dec 10, 2020 •
edited
Loading

Fixes urbit/landscape#92

joemfb
joemfb reviewed Dec 10, 2020
View reviewed changes
@tylershuster
Copy link
Contributor Author

Ok, the syntax should be "slightly tidier" but I am not good with computer. Nonetheless, it works!

@tylershuster tylershuster marked this pull request as ready for review December 10, 2020 21:56
@tylershuster tylershuster requested a review from joemfb December 10, 2020 22:23
joemfb
joemfb requested changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with :dbug or :file-server, but I'm fine with this assuming it works.

The addition to the pill will require further changes, and I've noted a couple style nits:

pkg/arvo/lib/pill.hoon Outdated
:: XX this whitelist needs to be reviewed
::
?. ?= ?(%css %hoon %html %js %json %md %png %txt %udon %umd)
?. ?= ?(%css %hoon %html %js %json %md %png %txt %udon %umd %woff2)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding these files to the pill is fine, but the same scry-format and serialization need to be applied below. And this will be a new case; we have @t and $wain, but no $octs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH I don't even know what I'm doing in this file I just heard there were pngs

Fang-
Fang- reviewed Dec 10, 2020
View reviewed changes
joemfb
joemfb approved these changes Dec 10, 2020
View reviewed changes
Copy link
Collaborator

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hoon changes LGTM.

Note that without the fonts in the pill, they will not be available in the UI until a ship gets an OTA. I guess whether that's ok is a requirements question for interface.

@tylershuster
Copy link
Contributor Author

bump

@Fang-
Copy link
Collaborator

Fang- commented Dec 15, 2020

Note that without the fonts in the pill, they will not be available in the UI until a ship gets an OTA. I guess whether that's ok is a requirements question for interface.

@vvisigoth thoughts? I'm inclined to just merge.

@tacryt-socryp
Copy link
Contributor

This LGTM as well.

@matildepark
Copy link
Contributor

Note that without the fonts in the pill, they will not be available in the UI until a ship gets an OTA.

shrug We'll keep a CDN fallback I suppose. @tylershuster

In we go!

@matildepark matildepark merged commit 584755d into urbit:release/next-userspace Jan 4, 2021
@matildepark
Copy link
Contributor

Oh wait, you make the JS changes here too. Well, we have a sec, if we could optimise with CDN fallback that would be ideal. First OTAs can be a half hour where new users would have Times New Roman Landscape™

@tylershuster
Copy link
Contributor Author

I should target release/next-userspace with that then?

@matildepark
Copy link
Contributor

Yes!

@tylershuster tylershuster mentioned this pull request Jan 6, 2021
Merged
@tylershuster tylershuster deleted the serve-woff branch January 6, 2021 22:47
@tylershuster tylershuster mentioned this pull request Feb 17, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fang- Fang- Fang- left review comments

@joemfb joemfb joemfb approved these changes

+1 more reviewer

@tacryt-socryp tacryt-socryp tacryt-socryp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

landscape

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tylershuster @Fang- @tacryt-socryp @matildepark @joemfb