Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@jamesacklin
Copy link
Contributor

Sets and clears the chat message author's name on click with hooks, rather than with a ref. Sets this message in Inter regardless if the author has set a nickname or not.

Fixes (urbit/landscape#331)[https://github.com/urbit/landscape/issues/331]

@jamesacklin jamesacklin marked this pull request as ready for review January 31, 2021 17:51
Copy link
Contributor

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I'm a sucker for abstract hooks, and we actually use this elsewhere (in the base hash indicator). I suppose the rule of three applies.

@matildepark matildepark merged commit 43231f7 into release/next-js Feb 1, 2021
@matildepark matildepark deleted the james/chat/copied-notice branch February 1, 2021 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants