Thanks to visit codestin.com
Credit goes to github.com

Skip to content

king: fix two space leaks leading to oom on ~def. #4558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2021
Merged

king: fix two space leaks leading to oom on ~def. #4558

merged 2 commits into from
Mar 22, 2021

Conversation

@pilfer-pandex
Copy link
Contributor

@pilfer-pandex pilfer-pandex commented Mar 6, 2021 •
edited
Loading

Before:
image
After:
image

@pilfer-pandex pilfer-pandex requested review from joemfb and jtobin March 6, 2021 19:26
jtobin
jtobin approved these changes Mar 8, 2021
View reviewed changes
Copy link
Contributor

@jtobin jtobin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heap / Haskell are both great. Nice job finding that nasty IPC leak in particular. 👍 👍

@vvisigoth
Copy link
Contributor

vvisigoth commented Mar 8, 2021 via email

joemfb
joemfb approved these changes Mar 10, 2021
View reviewed changes
Copy link
Collaborator

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! LGTM

@pilfer-pandex pilfer-pandex changed the base branch from master to release/next-vere March 22, 2021 19:28
@pilfer-pandex pilfer-pandex merged commit 965f179 into release/next-vere Mar 22, 2021
@Fang- Fang- deleted the pp/fix-leaks branch October 8, 2021 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemfb joemfb joemfb approved these changes

+1 more reviewer

@jtobin jtobin jtobin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pilfer-pandex @vvisigoth @joemfb @jtobin