Bitcoin Wallet #4940
Merged
Bitcoin Wallet #4940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd argue that this can and should go out to next-userspace before hitting master |
Idk if it can with the glob changes — janeway isn't updated to handle the new glob logic. But I like the intention. |
|
Could the glob changes be separately targeted to hit master? |
tacryt-socryp
approved these changes
May 26, 2021
3883eac to
b8ec17f
Compare
liam-fitzgerald
approved these changes
May 27, 2021
Anything I need to do here? Can't remember if I was supposed to update something and forgot.. 😝 |
(ah, nm) |
|
I've done the glob changes, PRing now |
jalehman
approved these changes
May 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is the bitcoin wallet
Beyond being just a bitcoin wallet, its also Tlon's first attempt at distributing multiple frontend packages. Includes 2 new hoon apps, a new pkg/btc-wallet, some changes to pkg/interface to make custom tiles work with images, and changes to glob to make it work with multiple packages.
Thanks to @timlucmiptev for writing the bulk of the backend code, and thanks to @pkova for contributing to both frontend and backend.
This is still somewhat of an alpha, so we are releasing this in an unstarted state. People who feel savvy enough to use this can
|start %btc-wallet