vere: fix bugs in replay error reporting #5380
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of bugs in event-replay error handling:
These bugs have been present since the IPC protocol rewrite in mid-2020. They're minor, in that replay errors are all currently fatal. But they're major, in that they preclude accurate error reporting, which is essential in determining if the error is (manually) recoverable (ie, was the failure deterministic?).
NB: errors on replay should (but do not yet) include context-dependent instructions for recovery procedures, or instruct the pilot to contact
[email protected].