webterm: backport #5454
webterm: backport #5454
Conversation
Doesn't quite compile, untested.
Additions and changes easily distinguishable for extermination once the new backend lands.
|
Thanks for your help @liam-fitzgerald! Small styling tweaks aside, this should be ready for review now. I could test this just fine against a fakezod. Connecting it to my live ship made eyre complain about the format of the json sent into the channel. "It's probably nothing", but, curious to hear if you can replicate or not. I'll update the |
This also helps conceal some xterm resizing inaccuracies.
There was a problem hiding this comment.
Changes LGTM in general, however:
looks like this is blocked on deploying a fix to +stap:
On a fakezod:
> `@t`(scan "/test/" stap)
/test/
On my livenet ship:
> `@t`(scan "/test/" stap)
syntax error
Looks like it doesn't like empty path segments, is there any way to work around this?
|
Oh, that's actually #5227, which our livenet ships have but our fakezods somehow don't. It makes Herm hasn't been updated to account for this, it expects subscription paths of the shape I suppose there's some case to be made that, if we accept empty segments in the middle of a path, we should accept them at the tail of a path as well. (Not to mention being able to Whatever the conclusion there though, it seems out of scope for this. Considering herm currently produces facts only on the |
append /view to the existing subscription paths to "wrap" the possibly empty path segment of the session name.
Make sure herm can only be interacted with by the local ship.
|
Since /app/herm is distributed with |
|
(fwiw tested on my live ship and Works Fine™) |
Backports the webterm changes from #4463.
Draft because this doesn't quite compile, and is untested.
@liam-fitzgerald I can run
npm run startfrompkg/interfacejust fine, but it doesn't pick up on webterm. Running it frompkg/interface/webtermcomplains about not being able to resolve imports, particularly the~/etc-style imports in non-webterm files.Whenever you have time, would love to get some advice and/or pair on setting this up right again.