helm: fix |rekey to work with multikey files #5570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I actually like the code as it exists in #5522 a little bit better. This does an unnecessary assignment to Any particular reason for these changes? (Seems functionally equivalent though.) |
|
Whoops, that's what I get for copying and pasting on a new branch without double checking instead of doing things the right way. Thanks for catching that. It was supposed to be identical to #5522. |
|
@Fang- OK now it should actually be identical. |
Fang-
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is identical to #5522, I was just asked to merge it into
next/arvoinstead ofrelease/next-userspace