Thanks to visit codestin.com
Credit goes to github.com

Skip to content

interface: use single sig in NotificationText #5610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2022
Merged

interface: use single sig in NotificationText #5610

merged 1 commit into from
Feb 25, 2022

Conversation

@tomholford
Copy link
Collaborator

Changes

The ProfileOverlay component expects a ship arg as a patp without the sig. This deSigs the ship value used in NotificationText.

This closes urbit/landscape#1376

Preview

image

@tomholford tomholford force-pushed the th/1376-groups-double-tilde branch from 0838c76 to d5164b6 Compare February 25, 2022 00:24
@tomholford tomholford changed the title ui: use single sig in NotificationText interface: use single sig in NotificationText Feb 25, 2022
@tomholford tomholford marked this pull request as ready for review February 25, 2022 00:26
@tomholford tomholford requested a review from arthyn February 25, 2022 00:27
liam-fitzgerald
liam-fitzgerald approved these changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@liam-fitzgerald liam-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should (confusingly) target next/groups, else LGTM

@liam-fitzgerald liam-fitzgerald changed the base branch from next/landscape to next/groups February 25, 2022 19:28
@tomholford tomholford force-pushed the th/1376-groups-double-tilde branch from d5164b6 to e366ab9 Compare February 25, 2022 21:23
@tomholford
interface: use single sig in NotificationText
5959b73 
The `ProfileOverlay` component expects a `ship` arg as a patp without the sig. This deSigs the ship value used in `NotificationText`.

This closes urbit/landscape#1376
@tomholford tomholford force-pushed the th/1376-groups-double-tilde branch from e366ab9 to 5959b73 Compare February 25, 2022 21:24
@tomholford tomholford merged commit e0c1e27 into next/groups Feb 25, 2022
@tomholford tomholford deleted the th/1376-groups-double-tilde branch February 25, 2022 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@arthyn arthyn Awaiting requested review from arthyn

1 more reviewer

@liam-fitzgerald liam-fitzgerald liam-fitzgerald approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tomholford @liam-fitzgerald