dill: exclude wrapped-task from most +call traces #6452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of including wrapped-task as-is in most call traces, we now only include it in traces for crashing (harden task) calls. For everything else, we include only the tag of the resulting $task. Closes #6444.
belisarius222
approved these changes
Apr 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of including wrapped-task as-is in most call traces, we now only include it in traces for crashing (harden task) calls. For everything else, we include only the tag of the resulting $task.
Closes #6444. That issue doesn't specify under what conditions this was observed. I imagine in the crashing
hardencase we'll still want to be able to inspect the noun. I still include the tag of the resulting task in the general trace, for clarity.