ames: make dead flow consolidation toggleable, default off #6792
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found that dead flow consolidation (#6738) can cause degenerate network behavior in scenarios where a ship has a tremendous amount of dead flows. This happens because sending a massive amount of traffic to galaxies in a very short period of time can overwhelm their forwarding queues which are currently set to 1000 messages.
We have made the conservative decision to make dead flow consolidation opt-in for 412,
|pass [%a %stir %dead]to toggle it on and off.Note that core developers and others that have been syncing off
~binnec-dozzod-marzodwill continue to have dead flow consolidation turned on unless they manually turn it off. I will personally keep mine turned on, but you may want to keep yours off if you run a busy publisher ship.