drum: prevent Dojo crash with M-c on certain characters #6889
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an off-by-one error in
wrd:offset. Previously, if M-c were used on a non-alphanumeric character and there were no alphanumeric characters between the position of the cursor and the end of the buffer,wrd:offsetwould increment its counter to a value one greater than the remaining length of the buffer. As a result, this+snagcall in/lib/solewould fail due to its using an out-of-bounds index, causing Dojo to crash and unlink:urbit/pkg/base-dev/lib/sole.hoon
Line 86 in 4576213
This fix corrects the issue by modifying
wrdto check if the next character is null (i.e. the end of the buffer) and if so to return the current value of the counter rather than incrementing, preventing the off-by-one error and resultant crash.Resolves #6864