Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ames: fix bug in dead flow consolidation toggle #6956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkova merged 3 commits into from
Apr 12, 2024
Merged

ames: fix bug in dead flow consolidation toggle #6956

pkova merged 3 commits into from
Apr 12, 2024

Conversation

@pkova
Copy link
Collaborator

@pkova pkova commented Mar 30, 2024

My refactor in #6823 that was released in 411 broke toggling dead flow consolidation because I remembered to cancel the behn timer but forgot to remove the timer from ames-state.

@pkova pkova force-pushed the pkova/dead-flow-fix branch from 507ecd4 to 7773f67 Compare March 30, 2024 18:11
@midden-fabler
Copy link
Contributor

midden-fabler commented Mar 31, 2024

the toggle works, but I'm seeing some of these:

crud: %ames-wake event failed
[%poke %wake]
wire=/pump/~sampel/33
bar-stack=[i=[i=/ames t=~] t=[i=[i=//behn t=~] t=~]]
take: failed
/sys/vane/ames/hoon:<[5.439 3].[5.465 20]>
/sys/vane/ames/hoon:<[5.440 3].[5.465 20]>
/sys/vane/ames/hoon:<[5.443 3].[5.465 20]>
/sys/vane/ames/hoon:<[5.445 3].[5.465 20]>
/sys/vane/ames/hoon:<[5.446 5].[5.463 7]>
/sys/vane/ames/hoon:<[5.449 5].[5.463 7]>
/sys/vane/ames/hoon:<[5.450 5].[5.463 7]>
/sys/vane/ames/hoon:<[5.456 24].[5.456 65]>
/sys/vane/ames/hoon:<[2.879 9].[2.938 74]>
/sys/vane/ames/hoon:<[2.880 9].[2.938 74]>
/sys/vane/ames/hoon:<[2.894 9].[2.938 74]>
/sys/vane/ames/hoon:<[2.897 9].[2.938 74]>
/sys/vane/ames/hoon:<[2.898 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.903 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.907 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.908 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.913 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.914 11].[2.921 13]>
/sys/vane/ames/hoon:<[2.915 20].[2.915 61]>
/sys/vane/ames/hoon:<[2.915 25].[2.915 61]>
/sys/vane/ames/hoon:<[3.683 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.686 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.707 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.710 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.711 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.712 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.719 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.732 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.740 11].[3.740 45]>
/sys/vane/ames/hoon:<[3.740 16].[3.740 45]>
/sys/vane/ames/hoon:<[3.981 13].[3.991 44]>
/sys/vane/ames/hoon:<[3.983 13].[3.991 44]>
/sys/vane/ames/hoon:<[3.983 23].[3.983 60]>
/sys/vane/ames/hoon:<[3.983 26].[3.983 46]>
/sys/vane/ames/hoon:<[3.998 13].[4.032 19]>
/sys/vane/ames/hoon:<[4.000 13].[4.032 19]>
/sys/vane/ames/hoon:<[4.003 22].[4.003 65]>
/sys/vane/ames/hoon:<[4.003 27].[4.003 65]>
/sys/vane/ames/hoon:<[4.258 15].[4.265 17]>
/sys/vane/ames/hoon:<[4.259 15].[4.265 17]>
/sys/vane/ames/hoon:<[4.262 24].[4.262 46]>
/sys/vane/ames/hoon:<[4.331 15].[4.368 60]>
/sys/vane/ames/hoon:<[4.334 15].[4.368 60]>

@pkova
Copy link
Collaborator Author

pkova commented Apr 4, 2024

@midden-fabler what about this one?

@pkova
Copy link
Collaborator Author

pkova commented Apr 12, 2024

I got a response out of band, yes it works.

@pkova pkova merged commit 68cdceb into develop Apr 12, 2024
@pkova pkova deleted the pkova/dead-flow-fix branch April 12, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkova @midden-fabler