Thanks to visit codestin.com
Credit goes to github.com

Skip to content

jael: notify gall the vane before notifying gall agents #6980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pkova merged 1 commit into from
May 3, 2024
Merged

jael: notify gall the vane before notifying gall agents #6980

pkova merged 1 commit into from
May 3, 2024

Conversation

@pkova
Copy link
Collaborator

@pkova pkova commented May 1, 2024

When testing %phoenix we discovered that a poke that the app sends when hearing about a breach was always dropped with a gall: missing message. This is because jael delivers breach notifications to gall the vane and gall agents in an undefined order.

Old behavior:

(sort `(list duct)`[[i=/gall/use/ping/0w3.psfYX/~dinleb-rambep/jael t=[i=/dill t=~[//term/1]]] [i=/gall/sys/era t=[i=/dill t=~[//term/1]]] ~] sorter)
~[[i=/gall/use/ping/0w3.psfYX/~dinleb-rambep/jael t=[i=/dill t=~[//term/1]]] [i=/gall/sys/era t=[i=/dill t=~[//term/1]]]]

New behavior:

(sort `(list duct)`[[i=/gall/use/ping/0w3.psfYX/~dinleb-rambep/jael t=[i=/dill t=~[//term/1]]] [i=/gall/sys/era t=[i=/dill t=~[//term/1]]] ~] sorter)
~[[i=/gall/sys/era t=[i=/dill t=~[//term/1]]] [i=/gall/use/ping/0w3.psfYX/~dinleb-rambep/jael t=[i=/dill t=~[//term/1]]]]

Here we fix jael to always notify the vane before notifying any agents by special casing the /sys wire.

@joemfb
Copy link
Collaborator

joemfb commented May 1, 2024

Vere segfaulted in CI. Retrying.

joemfb
joemfb approved these changes May 1, 2024
View reviewed changes
Copy link
Collaborator

@joemfb joemfb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a good catch

@pkova pkova merged commit eca32c4 into develop May 3, 2024
@pkova pkova deleted the pkova/jael-sort-gall branch May 3, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joemfb joemfb joemfb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pkova @joemfb