gall: delete agent blocked moves on |nuke #7063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Applied this fix to my live ship, seems to be working well. |
Collaborator
|
Spoke too soon, the long hangs after breaches are still occurring w/this fix. |
Collaborator
Author
|
You need to |
Collaborator
|
Alright, nuked it, will report back if I see the hanging again. |
Collaborator
|
Ok, my ship just processed 15 breaches and it was only unresponsive for about ~4 minutes, normally that would be 15 * 15 minutes. I'm guessing it was just unresponsive due to the large number being processed back-to-back? |
Collaborator
|
Could we also preemptively |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating #6794 by running a local copy of
~finned-palmer, manually breaching by doing|pass [%j %ruin [~dinleb-rambep ~ ~]]and observing the ship hang for a very long time. When I interrupted the ship by doing ctrl+c, the problem became quite evident.~finned-palmerwas spending all its' time in+mo-filter-queue. Specifically, it was iterating over 450 000 blocked moves to an agent called%push-notifytrying to find any moves from the ship that just breached. This is an agent from the long defunct%escape.This PR enables us to recover from scenarios where userspace programs do crazy stuff like this. It does potentially break some invariants, but I believe this to be worth it because this is a manual intervention.
@belisarius222 @joemfb