Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Fang-
Copy link
Collaborator

@Fang- Fang- commented Jul 3, 2024

We make two changes in the hopes of improving the UX of eauth, especially around its failure cases.

  1. Lower the eauth timeout from 5 minutes to 50 seconds.
  • This way we serve the user a formal error page much more eagerly. In practice, most commonly, remote scry for the eauth url either gets a response reasonably fast, or not at all.
  • Nginx, popularly used as a proxy server in front of urbit, times out connections after a minute unless configured otherwise. Setting the timeout to be slightly below that ensures eyre gets to serve an error page itself in those common setups.
  1. Lower the eauth url scry's case rounding from 1 hour down to 5 minutes.
  • The high value was interfering with UX around updated public urls. The strong rounding is supposed to give us more frequent scry cache hits, but highly questionable whether that actually matters in practice.
  • 5 minutes should still be plenty to avoid scry breakage due to clock skew in almost all cases (right?). "Wait up to five minutes for it to work" still isn't great, but it's much better than "up to an hour".
  • The most-correct answer here is scry-at-latest, and we should switch to using that whenever it arrives.

Fang- added 2 commits July 2, 2024 17:56
Serve the user a formal error page much more eagerly. In practice, most
commonly, remote scry for the eauth url either gets a response
reasonably fast, or not at all.

Nginx, popularly used as a proxy server in front of urbit, times out
connections after a minute unless configured otherwise. Setting the
timeout to be slightly below that ensures eyre gets to serve an error
page itself in those common setups.
The high value was interfering with UX around updated public urls. The
strong rounding is supposed to give us more frequent scry cache hits,
but highly questionable whether that actually matters in practice.

Here we lower it down from an hour to five minutes, which should still
be plenty to avoid scry breakage due to clock skew in almost all cases
(right?).

The most-correct answer here is scry-at-latest, and we should switch
to using that whenever it arrives.
@Fang- Fang- added the eyre label Jul 3, 2024
@Fang- Fang- requested a review from pkova July 3, 2024 11:23
@pkova pkova merged commit b466dfe into develop Jul 3, 2024
@pkova pkova deleted the m/eauth-tweaks branch July 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants