Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ames: migrate queued-message acks to |mesa #7161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yosoyubik wants to merge 46 commits into from
Closed

ames: migrate queued-message acks to |mesa #7161

yosoyubik wants to merge 46 commits into from

Conversation

@yosoyubik
Copy link
Collaborator

@yosoyubik yosoyubik commented May 12, 2025 •
edited
Loading

  • migrate pending-vane-acks on %ahoy
    • XX check empirically that %gall has in fact these messages enqueued
  • state migration to handle queued-message-acks
    • test migrations have shown peers that have queued-message-acks for future messages, but are still waiting to hear the acck for current (in some cases current is also missing from the packet pump) in order to process these acks in order, we need to migrate them and track them until current gets fully acked
    • migrate then in +on-migrate
    • handle them in the |fo core (+fo-take-ack/nax)
    • the missing ack is due to a naxplanation that references the wrong sequence number (i.e. not current)—see ames: assume ok when handling next pending-vane-ack #6998.
    • the solution is to issue +peeks for this naxplanations—that the other side will bind into its namespace when handling the %ahoy $plea. that will then start the processing of all these acks, issuing further +peeks when encountering a %nack (only %acks and %naxplanation are directly handled). This has been tested locally between ~norsyr-torryn and ~hiddev-dannut, resulting in %cork $pleas being processed between the two, that delete the flows

@yosoyubik yosoyubik force-pushed the yu/migrate-pending-ack branch from ce34fd3 to b61ade9 Compare May 14, 2025 06:59
@yosoyubik yosoyubik changed the base branch from develop to yu/remote-flubs June 13, 2025 08:29
@yosoyubik
Copy link
Collaborator Author

yosoyubik commented Jun 13, 2025

This PR is merged in the yu/remote-flubs branch here #7173, leaving it here to see the diff of the changes

@yosoyubik yosoyubik changed the base branch from yu/remote-flubs to develop June 25, 2025 06:51
@yosoyubik yosoyubik force-pushed the yu/migrate-pending-ack branch from 16ff7d6 to 9ddc9d5 Compare June 25, 2025 07:10
@yosoyubik yosoyubik force-pushed the yu/migrate-pending-ack branch from 4be7f9c to e4cd378 Compare June 30, 2025 09:53
yosoyubik added 9 commits July 1, 2025 07:20
@yosoyubik yosoyubik force-pushed the yu/migrate-pending-ack branch from f508033 to ea9c7ed Compare July 3, 2025 10:36
@yosoyubik yosoyubik force-pushed the yu/migrate-pending-ack branch from ea9c7ed to 0636fbd Compare July 3, 2025 10:37
@yosoyubik yosoyubik changed the title ames: don't drop pending acks in %ahoy migration ames: migrate queued-message acks to |mesa Jul 4, 2025
@yosoyubik yosoyubik mentioned this pull request Aug 5, 2025
Merged
pkova added a commit that referenced this pull request Aug 5, 2025
@pkova
Merge pull request #7195 from urbit/yu/test-mesa-pr
e5485be 
ames: merge #7161 and #7106
@yosoyubik yosoyubik closed this Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yosoyubik