fix muk jet #7198
Merged
fix muk jet #7198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joemfb
approved these changes
Jul 16, 2025
Collaborator
joemfb
left a comment
There was a problem hiding this comment.
This is a good catch, I didn't realize that data and blocks were not consistently padded.
I would prefer to see this jet rewritten to use +cut instead of materializing lists in bloq 3 and 5. That would also let the padding logic be implicit in the length/step calculation, as opposed to appending onto a list.
pkova
added a commit
to urbit/vere
that referenced
this pull request
Jul 21, 2025
Depends on urbit/urbit#7198. Previous registration was absurd anyway, it used `..muk` from pinned `+fe` instead of the actual context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two issues with hoon version of
+muk:+fecore is pinned outside of the definition of the jetted battery, leading to potential jet mismatches if+fecore in the head of the context of the gate is manipulated.The second is an actual mismatch: if the length
lenofkey, divided by four, is greater than the length ofnblockslist, then Nock version would crash due to the lack of padding innblocks. This is fixed by adding implicit padding in form of+snuggate.This commit changes the registration for
+muk, so it depends on urbit/vere#849.