-
Notifications
You must be signed in to change notification settings - Fork 361
dojo: stop thread after backspace cancel #7105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(note: %yawn still doesn't properly cancel the peek from %ames)
this map is useful to track what namepace path different listeners are using when, for example, using the same internal path (i.e. peeking for the same path using the %publ namespace with -meen, but also with the per-peer %chum namespace used in -chum). Here we track also what types of interest gifts different listeners expect. Originally this was either %tune (for |fine) or %sage (for |mesa) but we also add a %rate gift so subscribers can be notified of the progress of the +peek. (WIP: %yawn/%wham paths to cancel peeks)
all are subsumed by -peek
tl;dr: don't migrate the next seq number into the flow if this is a naxplanation bone, and make sure that we don't replace the contents of the flow if we later encounter a naxp bone, after having processed the reference one
(a backwas flow gets automatically deleted if it's actually peeking for a $cork)
pkova
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(note: %yawn still doesn't properly cancel the peek from %ames)