mesa: moar misc fixes #7123
Merged
mesa: moar misc fixes #7123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: this does more aggresive testing of the migrated state, resulting of slighlty more peers unable to migrate. Those peers have several unsent messages in their queue, and are probably offline. Mpre granular tests for these peers incoming soon.
Fixes a bug where we were resetting the next message in the sequence pump, when there we unsent-messages. Filtering the unsent message queue is only done if we encounter a $cork, possibly leaving duplicate leaves in it.
pkova
approved these changes
Mar 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are certain flows with tens of thousands of duplicated messages (most of them %leaves=[%0 %u ~]) that make these migrations slow. Here we start a partial flow amnesty that filters these duplicated messagesremoved. diuplicate %leaves will remain in the queue due to the complexity of special casing them in the test, to check that we are not introducing any bugs in the filtering logic