Thanks to visit codestin.com
Credit goes to github.com

Skip to content

hoon: fix how rend:co handles an empty %many $coin #7274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
will-hanlen wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

hoon: fix how rend:co handles an empty %many $coin #7274

will-hanlen wants to merge 1 commit into from

Conversation

@will-hanlen
Copy link
Contributor

@will-hanlen will-hanlen commented Dec 20, 2025 •
edited
Loading

the +so parser expects an empty %many $coin to be rendered as .___ (3 cabs):

> (rush '.___' nuck:so)
[~ [%many p=~]]

but the current implementation of +co prints it with only 2 cabs:

> ~(rend co [%many ~])
".__"

this change fixes the +co renderer so that a full-roundtrip is possible.

@will-hanlen
Copy link
Contributor Author

will-hanlen commented Dec 20, 2025

i suppose there's a question regarding whether an empty %many should be allowed.

the dojo say no because it turns the %many list into a tuple.

> ._4__
4
> ._4_a__
[4 %a]
> .___
dojo: hoon expression failed

but i think it would be more useful if an empty %many was allowed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@will-hanlen