Bugfix: Remove version flag from commands with subcommands #1153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rliebz
reviewed
Jun 18, 2020
command_test.go
Outdated
| HideHelp: true, | ||
| Action: func(c *Context) error { | ||
| if len(c.App.VisibleFlags()) != 0 { | ||
| t.Fatalf("unexpected flag on command") |
There was a problem hiding this comment.
Nit: Since there's no formatting here, t.Fatal is more appropriate.
Sure, added such one. |
coilysiren
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
This PR removes unexpected version flag on commands with subcommands.
Which issue(s) this PR fixes:
Fixes #1073
Testing
test added
Release Notes