Support PathFlag.TakesFile in fish completion #1198
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performing reflection on the given flag ensures that fishAddFileFlag will behave correctly if any flag types get a TakesFile field in the future.
rliebz
requested changes
Oct 22, 2020
rliebz
approved these changes
Oct 22, 2020
saschagrunert
approved these changes
Oct 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Flags of type
PathFlagweren't processed correctly when generating fish completions—the generatedcompletecommand told fish that the flag doesn't take a filename, even whenTakesFileis true.fish.gonow respects theTakesFilefield, regardless of the flag's underlying type.PathFlagto the list of explicit types in the switch statement.fish_test.gohas a test case for aPathFlagwithTakesFile = true.expected-fish-full.fishhas a corresponding change in its fixture data.Which issue(s) this PR fixes:
Fixes #1156
Special notes for your reviewer:
@lynncyrin had suggested a lighter-weight form of reflection, but I wasn't able to make the type assertion work. AFAIK go's type system only deals in interfaces and specific, concrete types.
Release Notes