Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Coderlane
Copy link
Contributor

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

This PR corrects the input arguments for a runnable example in the manual. I believe the test-cmd argument was removed in this change, but never removed from the input.

Which issue(s) this PR fixes:

(REQUIRED)

No issue yet, but this has been failing on all pull requests.

Release Notes

(REQUIRED)

NONE

This command has no name, so drop the `test-cmd` in `args`.
@Coderlane Coderlane requested a review from a team as a code owner January 25, 2021 02:04
@Coderlane Coderlane requested review from asahasrabuddhe and coilysiren and removed request for a team January 25, 2021 02:04
@coilysiren
Copy link
Member

O M G ✨ thank you! ✨

@coilysiren
Copy link
Member

@asahasrabuddhe / @saschagrunert / @rliebz a +1 here would be super appreciated 🙏🏼

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coilysiren coilysiren merged commit 8fb96e6 into urfave:master Jan 25, 2021
@Coderlane Coderlane deleted the doc_command branch January 26, 2021 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants