Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@rliebz
Copy link
Member

@rliebz rliebz commented Jan 4, 2022

What type of PR is this?

(REQUIRED)

  • bug
  • cleanup
  • documentation
  • feature

What this PR does / why we need it:

(REQUIRED)

Only support latest 3 versions, and more urgently, stop the binary size from failing CI on Go 1.14 (which we presumably no longer care about).

Which issue(s) this PR fixes:

(REQUIRED)

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

NONE

@rliebz rliebz requested a review from a team as a code owner January 4, 2022 03:52
@rliebz
Copy link
Member Author

rliebz commented Jan 4, 2022

@urfave/cli quick version bump if anyone is around to approve.

@rliebz
Copy link
Member Author

rliebz commented Jan 21, 2022

@saschagrunert @asahasrabuddhe if either of you have a minute to look this over, this fixes the broken pipeline in the main branch.

Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saschagrunert saschagrunert merged commit 5d61a2f into urfave:master Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants