Don't call open("") #1336
Merged
Don't call open("") #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strings.Split(s, sep) returns a slice of a single element containing s if sep is not found in s. This is true even if s is empty. As a result, every call to flagFromEnvOrFile results in an attempt to open a file with empty name. This is seen from strace as [pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) [pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) ... To fix, check if the string is empty before calling ReadFile. This also fixes cases where filePath is non-empty but has extra commas. Signed-off-by: Kir Kolyshkin <[email protected]>
kolyshkin
added a commit
to kolyshkin/cli-1
that referenced
this pull request
Apr 22, 2022
strings.Split(s, sep) returns a slice of a single element containing s if sep is not found in s. This is true even if s is empty. As a result, every call to flagFromEnvOrFile results in an attempt to open a file with empty name. This is seen from strace as [pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) [pid 3287620] openat(AT_FDCWD, "", O_RDONLY|O_CLOEXEC) = -1 ENOENT (No such file or directory) ... To fix, check if the string is empty before calling ReadFile. This also fixes cases where filePath is non-empty but has extra commas. Signed-off-by: Kir Kolyshkin <[email protected]> (cherry picked from commit 3df9a3c) Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
strings.Split(s, sep)returns a slice of a single element containing sif sep is not found in s. This is true even if s is empty.
As a result, every call to flagFromEnvOrFile results in an attempt to
open a file with empty name. This is seen from strace as
To fix, check if the string is empty before calling ReadFile.
This also fixes cases where filePath is non-empty but has extra commas.
Which issue(s) this PR fixes:
none
Special notes for your reviewer:
none
Testing
Due to the obvious nature of the fix, no additional testing is required.
Release Notes