[v1] fix CI, add Go 1.17.x and 1.18.x #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test is failing with Go 1.17+ since it now panics instead of returning an error. Catch the panic and consider the test passed. With that out of the door, add Go 1.17.x and 1.18.x to the testing matrix. While at it, do not use && in run since it is executed by a shell with set -e, thus making && redundant. Signed-off-by: Kir Kolyshkin <[email protected]>
meatballhat
approved these changes
Apr 28, 2022
Comment on lines
-41
to
+36
| go run build.go vet && | ||
| go run build.go test && | ||
| go run build.go vet | ||
| go run build.go test |
There was a problem hiding this comment.
TIL that the default is to run with set -e 😯 !
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
One test is failing with Go 1.17+ since it now panics instead of
returning an error. Catch the panic and consider the test passed.
With that out of the door, add Go 1.17.x and 1.18.x to the testing
matrix.
While at it, do not use && in run since it is executed by a shell with
set -e, thus making && redundant.
Which issue(s) this PR fixes:
None (AFAICS)
Special notes for your reviewer:
None
Testing
That's what we have CI for!
Release Notes