Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix:(issue_2169) Allow trim space for string slice flags #2171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 9, 2025
+23 −1
Merged

Fix:(issue_2169) Allow trim space for string slice flags #2171

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions command_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4311,6 +4311,9 @@ func TestCommandReadArgsFromStdIn(t *testing.T) {
},
&StringSliceFlag{
Name: "ssf",
Config: StringConfig{
TrimSpace: true,
},
},
}

Expand Down
15 changes: 14 additions & 1 deletion flag_slice_base.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,21 @@ func (i *SliceBase[T, C, VC]) Set(value string) error {
return nil
}

trimSpace := true
// hack. How do we know if we should trim spaces?
// it makes sense only for string slice flags which have
// an option to not trim spaces. So by default we trim spaces
// otherwise we let the underlying value type handle it.
var t T
if reflect.TypeOf(t).Kind() == reflect.String {
trimSpace = false
}

for _, s := range flagSplitMultiValues(value) {
if err := i.value.Set(strings.TrimSpace(s)); err != nil {
if trimSpace {
s = strings.TrimSpace(s)
}
if err := i.value.Set(s); err != nil {
return err
}
*i.slice = append(*i.slice, i.value.Get().(T))
Expand Down
6 changes: 6 additions & 0 deletions flag_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -350,6 +350,12 @@ func TestFlagsFromEnv(t *testing.T) {
output: []string{"foo", "bar"},
fl: &StringSliceFlag{Name: "names", Sources: EnvVars("NAMES"), Config: StringConfig{TrimSpace: true}},
},
{
name: "StringSliceFlag valid without TrimSpace",
input: "foo , bar ",
output: []string{"foo ", " bar "},
fl: &StringSliceFlag{Name: "names", Sources: EnvVars("NAMES")},
},

{
name: "StringMapFlag valid",
Expand Down
Loading