Cleanup TODOs & unskip tests #108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezylstra
reviewed
Jun 14, 2025
There was a problem hiding this comment.
When I installed rnpn at this stage (#108 ), I still got unhelpful error messages when npn_get_data() didn't return any records. However, I think the issue is subsequently resolved with fixes in #123.
I think everything else looks good, though I didn't go through all the changes made to tests since that's not stuff I'm yet familiar with.
Merged
|
Ok, merging one more PR to go into the CRAN patch. This unskips some tests, but anything without a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npn_createArgList()and replaces fully withexplode_query()climate_dataargument is length 1 logicalnpn_get_data()when an empty list is returned. Was producing an uniformative error, now returns an emtpy tibblevcr