Convert -9999 to NA for additional data
#121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is a failing test that looks like the order of rows returned by the API changed compared to the stored the mocked API response. @jeffswitzer — earlier I said this was an R code thing, not an API thing, but I think I was wrong about that. This test also fails on the master branch, so I think the order of observations returned by the API must have changed. Not a big deal, and we can definitely do our own sorting in the R package, but just FYI. I'll just re-generate the mocked response for this PR. |
NA for additional data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #119 by simply moving the conversion of -9999 to NA later in the
wrangle_dl_data()function.