Dev vcr changes #125
Merged
Dev vcr changes #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check_cassette_names is being deprecated, you can wait until the next version of vcr for it to be removed but might as well remove now.
in addition, I see some errors running tests - i suggest installing dev vcr `pak::pak("ropensci/vcr")` and re-recording cassettes
|
Friendly reminder that you'll very likely need to send a new version to CRAN with changes for the new version of vcr |
|
Thanks for the PR Scott! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check_cassette_names is being deprecated, you can wait until the next version of vcr for it to be removed but might as well remove now.
in addition, I see some errors running tests - i suggest installing dev vcr
pak::pak("ropensci/vcr")and re-recording cassettes