Cast shape, maxshape and total_size to (double) #113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
Testingcreated a file in h5py like this: import h5py
import numpy as np
data = np.zeros((1, 5489389, 395), dtype="float32")
with h5py.File("issue_111.h5", "w") as output:
output.create_dataset("data", data=data, chunks=(1, 1000, 395), compression=5)Then in nodejs: const h5wasm = await import("h5wasm/node");
await h5wasm.ready;
const f = new h5wasm.File("issue_111.h5", "r");
// File {
// path: '/',
// file_id: 72057594037927936n,
// type: 'Group',
// filename: 'issue_111.h5',
// mode: 'r'
// }
f.get("data").metadata;
// {
// signed: false,
// type: 1,
// vlen: false,
// littleEndian: true,
// size: 4,
// total_size: 2168308655,
// shape: [ 1, 5489389, 395 ],
// maxshape: [ 1, 5489389, 395 ],
// chunks: [ 1, 1000, 395 ]
// } |
axelboc
approved these changes
Dec 17, 2025
Collaborator
axelboc
left a comment
There was a problem hiding this comment.
Neat! That memory allocation error is most likely going to be quite useful.
|
|
||
| function check_malloc(nbytes: bigint | number) { | ||
| const max_memory = Module.MAXIMUM_MEMORY; | ||
| if (nbytes > max_memory) { |
Collaborator
There was a problem hiding this comment.
I would convert to safe_nbytes before checking, because > will throw if the two operands aren't both number. Though is this ever called with a bigint?
Member
Author
There was a problem hiding this comment.
Comparison operators do an automatic conversion (unlike arithmetic operators), but you're right that it's probably only called with number type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #111 in a direct way:
In the C library for h5wasm, the values for
shape,maxshapeandtotal_sizeare read from the HDF5 library as typehsize_t, which is an alias foruint64_t(or arrays of this type, forshapeandmaxshape). This PR casts these values to(double)before returning them to the Javascript code in themetadatastructure.The C
(double)precision exactly maps onto the JavascriptNumbertype, which is what we want to use.The PR also introduces a new function
check_malloc(nbytes: number | bigint): number;that returns a pointer after checking: