USWDS - Remove unnecessary single quote in sortable table aria-labels #5280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed a typo in the sortable table JavaScript that caused the
aria-label
in table headers to have an unnecessary single quote.This PR also includes fixes for a couple
lintSass
errors. (A couple of files just needed to have some extra spaces removed.)Breaking change
This is not a breaking change.
Related issue
Closes #5261
Related pull requests
Changelog entry: uswds/uswds-site#2098
Preview link
Preview link: Sortable table component
Problem statement
Due to a typo, the
index.js
script creates anaria-label
with an unncessary single quote in sortable table headers.Solution
Removed the single quote from the
index.js
script.Testing and review
Confirm that the aria labels for sortable table headers have no single quote after the header name.
For example, the table header for the first column in the first example should have
instead of the previous: