Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Mar 24, 2023

Summary

Fixed the side navigation on the form templates page to show the address, name, password reset, and sign-in form pages.

Related issue

Closes #2035

Changelog pathing issues will be resolved in issue #2036

Preview link

Preview link: Form templates page

Problem statement

The address, name, password reset, and sign-in form pages are not visible in the form template page's side navigation.

Solution

Removing a redundant subnav declaration allowed the side navigation to build correctly.

Note: This PR also updates the path for the Form templates changelog link because it was breaking when trying to access it from a child page like Address form.

Testing and review

To review, confirm that all related form template pages are accessible in its side navigation.

@amyleadem amyleadem marked this pull request as ready for review March 24, 2023 22:35
@amyleadem amyleadem marked this pull request as draft March 24, 2023 22:35
@amyleadem amyleadem marked this pull request as ready for review March 24, 2023 22:57
@amyleadem amyleadem requested review from mahoneycm and mejiaj March 24, 2023 23:10
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@mejiaj mejiaj merged commit 4857406 into main Apr 14, 2023
@mejiaj mejiaj deleted the al-fix-form-templates-sidenav branch April 14, 2023 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

USWDS-Site - Bug: Form templates missing

3 participants