USWDS-Site - Header: Update changelog for #5008 with note about possible break #2053
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 6, 2023 14:53
This alerts users to a possible breaking change caused by changing the hard-coded value of 50% to the default setting value of 33%
mahoneycm
approved these changes
Apr 7, 2023
Co-authored-by: mahoneycm <[email protected]>
mejiaj
approved these changes
Apr 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updated the changelog entry for USWDS PR #5008 so that it warns users of a potential breaking change.
The break was originally flagged in Slack: https://gsa-tts.slack.com/archives/C3F14AHSQ/p1680208085858799
I have updated the PR description with the same information. We should also consider updating the 3.4.1 release notes.
Related issue
Closes #2051
Preview link
Preview link: Header changelog
Testing and review