USWDS - Docs: Remove font smoothing #2066
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
April 24, 2023 11:02
Seen in light text examples in `utilities/color/#background-color`
Example: `/templates/docs`
Example: `/documentation/settings` (The text inside the tags)
Example: `/utilities/border` (Buttons that show states)
5bc434a to
67e4c19
Compare
2 tasks
added 2 commits
July 19, 2023 08:12
mejiaj
commented
Jul 19, 2023
There was a problem hiding this comment.
is-inverse is a site style that contained font smoothing mixin.
amyleadem
approved these changes
Jul 19, 2023
There was a problem hiding this comment.
Thanks for the fix on this, @mejiaj. It is nice to see those warnings go away.
- Confirmed that
is-inversewas used only for font smoothing and can be safely removed - Confirmed that all instances of
is-inverseandadd-knockout-font-smoothinghave been removed from the code base - Confirmed that this change removes all font-smoothing warnings when running
gulp compile - Confirmed there is no need for a changelog entry here
- Confirmed no visual regressions on affected pages
mahoneycm
approved these changes
Jul 20, 2023
thisisdano
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove font smoothing feature from site. Removes font-smoothing from guidance. Font smoothing mixins also removed to avoid deprecation warning.
Related issue
Closes #2195. Related to uswds/uswds#5180.
Preview link
Preview link:
Changelog entry. This was added in PR Add font-face update documentation #2022.Problem statement
Font smoothing was being used in site styles.
Solution
Major changes
Font smoothing removed from site styles.
Testing and review
Verify changelog entry