USWDS-Site: Header - Add changelog entry for megamenu fix. #2111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amyleadem
suggested changes
May 31, 2023
package.json
Outdated
| "dependencies": { | ||
| "@uswds/compile": "^1.0.0-beta.3", | ||
| "@uswds/uswds": "^3.4.1" | ||
| "@uswds/uswds": "github:uswds/uswds#jm-extended-megamenu-bug-5305" |
There was a problem hiding this comment.
Just making a visible comment as a reminder to revert this branch update :)
There was a problem hiding this comment.
Great idea. This is clearer than the PR description note, though both might be useful. Thanks!
| type: component | ||
| changelogURL: | ||
| items: | ||
| - date: TK |
There was a problem hiding this comment.
I noticed that the 3.5.0 changelog PR uses this date format. I think it would be good if we made it standard practice moving forward to reduce possible errors in the future.
Suggested change
| - date: TK | |
| - date: NNNN-NN-NN |
24 tasks
Co-authored-by: Amy Leadem <[email protected]>
Co-authored-by: Amy Leadem <[email protected]>
- Adjust table spacing - Add placeholder text for dates
amyleadem
approved these changes
Jun 2, 2023
thisisdano
approved these changes
Jun 6, 2023
thisisdano
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added changelog entry for header megamenu code example fix.
Related PR
Related to fix in uswds/uswds#5311.
Preview link
Preview link:
Solution
Updates changelog & Header with megamenu examples.